fix(sentry): sentry information now coming from bff #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
n3rdc4ptn
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR migrates Sentry configuration from build-time environment variables to runtime server configuration, enabling proper Sentry functionality in production builds. It also modernizes the development tooling by replacing ts-node with tsx.
- Updates Sentry configuration to fetch from BFF endpoint instead of build-time variables
- Replaces ts-node with tsx for improved development setup compatibility
- Adjusts Content Security Policy to support Sentry's runtime requirements
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.js | Adds telemetry disable flag and ESNext target for top-level await support |
| src/mount.ts | Implements runtime Sentry config fetching from /sentry endpoint |
| server/config/env.ts | Renames environment variables from VITE_* to FRONTEND_* prefix |
| server.ts | Adds /sentry endpoint and updates CSP to allow Sentry scripts |
| package.json | Replaces ts-node with tsx and restructures build scripts |
| .env.template | Updates environment variable names to match new naming convention |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| // Validate sentryConfig format | ||
| function isValidSentryConfig(config: unknown): config is SentryConfig { |
andreaskienle
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the sentry implementation to work again in production builds.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Introduces tsx instead of ts-node which is working with the new configuration in dev setup.