-
Notifications
You must be signed in to change notification settings - Fork 3
feat: rework breadcrumbs #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the breadcrumb system to remove static hierarchy levels and create a more streamlined navigation experience. The breadcrumbs now show only the actual path elements (Projects > project name > workspace name > MCP name) instead of including intermediate levels like "/ Workspaces /" or "/ MCPs /".
- Replaces the old
IntelligentBreadcrumbs
component with a newPathAwareBreadcrumbs
component - Creates a dedicated
BreadcrumbFeedbackHeader
component to encapsulate the breadcrumb and header functionality - Updates all breadcrumb references across the application to use the new naming convention
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/views/ProjectList.tsx | Updates import and component reference to use new breadcrumb component |
src/spaces/onboarding/pages/ProjectPage.tsx | Updates import and component reference to use new breadcrumb component |
src/spaces/mcp/pages/McpPage.tsx | Updates import and component reference to use new breadcrumb component |
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.tsx | New component implementing streamlined breadcrumb logic with path-aware navigation |
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.cy.tsx | Comprehensive test suite for the new breadcrumb component |
src/components/Core/LandscapeLabel.tsx | Removed as landscape label is now integrated into breadcrumb component |
src/components/Core/IntelligentBreadcrumbs.tsx | Removed old breadcrumb implementation |
src/components/Core/BreadcrumbFeedbackHeader.tsx | New component combining breadcrumbs with feedback buttons and logout menu |
src/Routes.ts | New constants file defining application route patterns |
public/locales/en.json | Updates translation keys to match new component naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.cy.tsx
Outdated
Show resolved
Hide resolved
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.cy.tsx
Outdated
Show resolved
Hide resolved
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.cy.tsx
Outdated
Show resolved
Hide resolved
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.cy.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Implements openmcp-project/backlog#289
This PR reworks our breadcrumbs:
ManagedControlPlane
subtitle to the MCP page to give users some contextThe breadcrumbs now look like this:
Home / project list:

Project:

MCP:
