Skip to content

Conversation

andreaskienle
Copy link
Contributor

@andreaskienle andreaskienle commented Sep 19, 2025

Implements openmcp-project/backlog#289

This PR reworks our breadcrumbs:

  • removes static hierarchy levels like "/ Workspaces /" or "/ MCPs /"
  • adds a ManagedControlPlane subtitle to the MCP page to give users some context
  • refactors the coding

The breadcrumbs now look like this:

  • Home / project list:
    image

  • Project:
    image

  • MCP:
    image

@andreaskienle andreaskienle marked this pull request as ready for review September 19, 2025 15:19
@Copilot Copilot AI review requested due to automatic review settings September 19, 2025 15:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the breadcrumb system to remove static hierarchy levels and create a more streamlined navigation experience. The breadcrumbs now show only the actual path elements (Projects > project name > workspace name > MCP name) instead of including intermediate levels like "/ Workspaces /" or "/ MCPs /".

  • Replaces the old IntelligentBreadcrumbs component with a new PathAwareBreadcrumbs component
  • Creates a dedicated BreadcrumbFeedbackHeader component to encapsulate the breadcrumb and header functionality
  • Updates all breadcrumb references across the application to use the new naming convention

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/views/ProjectList.tsx Updates import and component reference to use new breadcrumb component
src/spaces/onboarding/pages/ProjectPage.tsx Updates import and component reference to use new breadcrumb component
src/spaces/mcp/pages/McpPage.tsx Updates import and component reference to use new breadcrumb component
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.tsx New component implementing streamlined breadcrumb logic with path-aware navigation
src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.cy.tsx Comprehensive test suite for the new breadcrumb component
src/components/Core/LandscapeLabel.tsx Removed as landscape label is now integrated into breadcrumb component
src/components/Core/IntelligentBreadcrumbs.tsx Removed old breadcrumb implementation
src/components/Core/BreadcrumbFeedbackHeader.tsx New component combining breadcrumbs with feedback buttons and logout menu
src/Routes.ts New constants file defining application route patterns
public/locales/en.json Updates translation keys to match new component naming

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andreaskienle andreaskienle merged commit e222f8a into main Sep 25, 2025
5 checks passed
@andreaskienle andreaskienle deleted the ft/breadcrumbs branch September 25, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants