YAML view improvements #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a 'showOnlyImportantData' prop to YAML viewer components, allowing users to toggle the display of only essential YAML fields. Updates related components and dialog to support this feature and propagate state.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the YAML viewing functionality by introducing a filter to show only important fields and improving data handling. The main purpose is to provide users with cleaner YAML views while maintaining the ability to copy the full resource data.
Key changes:
- Replaced
removeManagedFieldsPropertywith a more comprehensiveremoveManagedFieldsAndFilterDatafunction - Added a checkbox option to toggle between filtered and full YAML views
- Enhanced the YAML viewer to support separate display and copy strings
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/removeManagedFieldsProperty.ts | Removed old utility function |
| src/utils/removeManagedFieldsAndFilterData.ts | Added enhanced utility with filtering capabilities |
| src/lib/api/types/shared/keyNames.ts | Added Kubernetes annotation constant |
| src/components/Yaml/YamlViewer.tsx | Enhanced with separate display/copy strings and conditional download button |
| src/components/Yaml/YamlViewDialog.tsx | Added checkbox for toggling important fields filter |
| src/components/Yaml/YamlViewButtonWithLoader.tsx | Integrated filter state management |
| src/components/Yaml/YamlViewButton.tsx | Updated to use new filtering function and state |
| src/components/Yaml/YamlLoader.tsx | Enhanced with filter support and memoized YAML strings |
| src/components/Graphs/Graph.tsx | Updated import to use new filtering function |
| public/locales/en.json | Added localization for the new filter checkbox |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
andreaskienle
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added checkbox that is checked by default to show only important YAML fields during preview of the resources