feat: add YAML splitter #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the YAML viewing functionality from a modal dialog approach to a side panel splitter layout. The main change is migrating from YamlViewDialog to a new splitter-based system that displays YAML content in a resizable side panel.
- Introduces a new splitter context and layout system for managing side panels
- Refactors YAML viewing components to work with the new splitter approach
- Updates all YAML button implementations to use the unified
YamlViewButtoncomponent
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/AppRouter.tsx | Wraps the application in the new SplitterProvider and SplitterLayout |
| src/components/Splitter/*.tsx | Implements the new splitter context and layout system |
| src/components/Yaml/YamlViewButton.tsx | Refactored to support both resource and loader variants with splitter integration |
| src/components/Yaml/YamlSidePanel*.tsx | New side panel components for displaying YAML content |
| src/components/Yaml/YamlViewer.tsx | Simplified by removing UI controls, now just displays syntax-highlighted YAML |
| src/components/Yaml/YamlViewDialog.tsx | Removed - replaced by splitter approach |
| src/components/Yaml/YamlViewButtonWithLoader.tsx | Removed - functionality merged into unified YamlViewButton |
| Various component files | Updated to use the new YamlViewButton API with variant specification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the YAML splitter (implementing openmcp-project/backlog#294)
2025-10-01_14-36-28.mp4