fix: breadcrumbs key #314
Merged
fix: breadcrumbs key #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a React console error caused by duplicate keys in the breadcrumbs component by switching from using path as the key to using the array index.
- Replaces
item.pathwithindexas the React key prop to resolve duplicate key warnings - Maintains the
data-targetattribute using the originalitem.pathvalue
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hubert-Szczepanski-SAP
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the console error with duplicate keys in the breadcrumbs.
Since paths aren’t unique (yet!), I’ve switched the
keyfrompathtoindex. This should be fine for now, as the items are static.