Illustrated Banner Component #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskienle
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Nice! Just some minor remarks.
Also the CSS file IllustratedBanner.css is empty – can we delete it?
I haven’t checked all the cases where the banner/error component is used in detail. Trust that the implementation is correct, especially with the types (error.message) 🤞🏻
src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx
Outdated
Show resolved
Hide resolved
Hubert-Szczepanski-SAP
force-pushed
the
feature/illustrated-banner-common-component
branch
from
74b26db to
1ec7205
Compare
Hubert-Szczepanski-SAP
force-pushed
the
feature/illustrated-banner-common-component
branch
from
d3fbc9b to
50976d9
Compare
Hubert-Szczepanski-SAP
deleted the
feature/illustrated-banner-common-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Common component to handle all INFO and Error banner with the same styling and positioning.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: