-
Notifications
You must be signed in to change notification settings - Fork 3
Refactor: Rework DocLinkCreator class #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍🏻
I’ve added two small suggestions that should be quick to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I only wonder if we should deconstruct the object like this
const { githubIssuesSupportTicket } = useLink();
Maybe it is better to not deconstruct it but use it like this:
const links = useLink();
and then { links.githubIssuesSupportTicket }
but this is only matter of style
Would also be a valid approach! It's implemented as specified in the backlog item. Since we'll be revisiting the whole topic of links soon anyway, we can always re-evaluate then. 🙂 |
useLink() hook
Deleted DocLinkCreator enitrely.
Using FrontendConfig directly
Current implementation only handles documentationBaseUrl. How can we implement githubUrl - the github issues link for example? To test currently please add const { documentationHomepage } = useLink(); to login.tsx