Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lh689 smartypants filter #224

Merged
1 commit merged into from
Feb 4, 2011

Conversation

danwolfgang
Copy link
Member

No description provided.

…ants, and fix the SmartyPants filter. Bumped to v1.0.3.
@jayallen
Copy link
Member

jayallen commented Feb 4, 2011

Wait, Dan did the presence of the perl files affect the plugin?

@danwolfgang
Copy link
Member Author

Yes, the perl versions of the plugin were being used, not the config.yaml. After removing the .pls, I found that it still wasn't working and made a change to call the SmartyPants method correctly.

@jayallen
Copy link
Member

jayallen commented Feb 4, 2011

So if you put the perl plugins back now does everything still work? The perl plugins should be completely ignored if the config.yaml initialization succeeds. If not, please file a bug against the plugin framework assigned to me.

@danwolfgang
Copy link
Member Author

I added the perl plugins back in, and everything works properly. So perhaps because the configy.yaml version of the plugin was failing it was falling back to the .pl plugin? Anyway, it's all good now.

@jayallen
Copy link
Member

jayallen commented Feb 7, 2011

That must be the case. I added unit tests (420ea26 and a87ba82) to make sure all was working as desired with the plugin init framework so I'm at least confident about that part.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants