Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Notification API specification #1228

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

chrisgacsal
Copy link
Contributor

Overview

  • remove featureId and subjectID fields from Notification Event object as the payload will include this information for relevant Event types
  • fix formatting, typos, descriptions

* remove `FeatureId` and `SubjectID` fields from Notification Event
  object as the _payload_ will include this information for relevant
  Event types.
* fix formatting, typos, descriptions
@chrisgacsal chrisgacsal requested review from tothandras and turip July 23, 2024 11:34
@chrisgacsal chrisgacsal self-assigned this Jul 23, 2024
@chrisgacsal chrisgacsal added area/api release-note/misc Miscellaneous changes kind/refactor Code refactor, cleanup or minor improvement labels Jul 23, 2024
@chrisgacsal chrisgacsal changed the title Notifications api spec refactor Notification API specification Jul 23, 2024
@chrisgacsal chrisgacsal changed the title refactor Notification API specification refactor: Notification API specification Jul 23, 2024
@chrisgacsal chrisgacsal merged commit 27759a9 into main Jul 23, 2024
22 checks passed
@chrisgacsal chrisgacsal deleted the notifications-api-spec branch July 23, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/refactor Code refactor, cleanup or minor improvement release-note/misc Miscellaneous changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants