feat: use plan phase duration and index instead of start after #1996
+3,974
−8,152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekike
requested changes
Dec 29, 2024
| @@ -83,6 +83,8 @@ func (PlanPhase) Fields() []ent.Field { | |||
| field.String("plan_id"). | |||
| NotEmpty(). | |||
| Comment("The plan identifier the phase is assigned to."), | |||
| field.Int("index"). | |||
| var ( | ||
| _ models.Validator = (*PlanMeta)(nil) | ||
| _ models.Equaler[PlanMeta] = (*PlanMeta)(nil) | ||
| ) | ||
|
|
||
| type PlanMeta struct { |
There was a problem hiding this comment.
Why is this called PlanMeta? Is this the internal model of Plan?
| type NextPlanInput struct { | ||
| // NamespacedID | ||
| models.NamespacedID | ||
| // type NextPlanInput struct { |
There was a problem hiding this comment.
The functionality provided by NextPlan API is also available via CreatePlan API. The only difference is that the former allows creating a new version with optinal plan payload while the latter requires a plan to be sent as part of the request. But I tend to agree that it does not worth to keep/maintain 2 API endpoints for the same operation.
|
I'm splitting this PR into multiple commits: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: