Subscription Alignment #2210
Merged
Subscription Alignment #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAlexIHU
force-pushed
the
feat/subs-alignment-2
branch
from
92ca733 to
3e04e75
Compare
GAlexIHU
force-pushed
the
feat/subs-alignment-2
branch
from
f9fb574 to
e7b97b4
Compare
turip
approved these changes
Feb 6, 2025
| @@ -78,6 +78,7 @@ func (InvoiceLineManagedBy) Values() []string { | |||
|
|
|||
| // Period represents a time period, in billing the time period is always interpreted as | |||
| // [from, to) (i.e. from is inclusive, to is exclusive). | |||
| // TODO: Lets merge this with recurrence.Period | |||
| @@ -18,6 +18,8 @@ type SubscriptionItem struct { | |||
| // The defacto cadence of the item is calculated and persisted after each change. | |||
| models.CadencedModel `json:",inline"` | |||
|
|
|||
| BillingBehaviorOverride BillingBehaviorOverride `json:"billingBehaviorOverride"` | |||
There was a problem hiding this comment.
nit: as far as I see we only use the Subscription level override, but not this one.
There was a problem hiding this comment.
This is part of the reset-anchor logic (that is partially implemented in this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Alignment consists of 2 concepts:
This PR introduces a limited set of features working towards these goals
Contents:
Timingconcept: changes can take effect at some special enumerated times (e.g. end of billing cycle, immediately)alignment.BillablesMustAlignfor Subscriptions too: inherited from plan setting (or custom input), cannot be changed. If true, any phase with billable items can have at most 1BillingCycleBillingPeriodfor a givenSubscriptionPhase: dynamically calculated from subscription contents for alignment enforced subscriptionsChanges:
invoiceAttimes are used for the created linesrecurrencepackage