Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickstart): use unified meters #652

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Conversation

hekike
Copy link
Contributor

@hekike hekike commented Mar 2, 2024

Update quickstart and example meters to follow common meters:
https://openmeter.io/docs/getting-started/meter-examples

@hekike hekike added kind/documentation Improvements or additions to documentation release-note/ignore Ignore this change when generating release notes labels Mar 2, 2024
Copy link
Contributor

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update other examples (collectors) as well?

@hekike
Copy link
Contributor Author

hekike commented Mar 4, 2024

@sagikazarmark I created a separate issue about updating examples: #657

@hekike hekike requested a review from sagikazarmark March 4, 2024 19:36
@sagikazarmark
Copy link
Contributor

Please make sure to squash commits (that merge commit triggers me)

@hekike hekike merged commit 9c33804 into main Mar 4, 2024
17 of 18 checks passed
@hekike hekike deleted the feat/quickstart-meter-update branch March 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation release-note/ignore Ignore this change when generating release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants