feat: auth flow #1
Merged
+2,493
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ui at this stage looks following
|
tobias-oetzel
requested changes
Jul 25, 2024
| name: ' ', | ||
| email: 'john.doe@example.com', | ||
| description: 'john.doe@example.com', | ||
| picture: 'https://avatars.wdf.sap.corp/avatar/user123', |
src/lib/services/auth.service.ts
Outdated
| name: `${firstName} ${lastName}`, | ||
| email: mail, | ||
| description: mail, | ||
| picture: `https://avatars.wdf.sap.corp/avatar/${sub}`, |
There was a problem hiding this comment.
internal url - for now we can skip the picture. I think gardener had a solution for this using https://gravatar.com/
so maybe we can have an api to provide the picture
There was a problem hiding this comment.
I skiped the picture and regarding the ' gardener had a solution for this using https://gravatar.com/' I think it can be a good task for Rafał to work on at some point in time
tobias-oetzel
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implemntation concerning the creation of auth flow.