Start adding static type checking #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
added
quality
github-actions bot
pushed a commit
to eddiebergman/automlbenchmark
that referenced
this pull request
Jul 21, 2023
* Remove commented out code * Specify mypy python version * Address mypy errors * Fix mypy errors * Fix mypy errors * Add type annotations * Add type checking requirements * Add ignore for [attr-defined], raised by normal Namespace use
github-actions bot
pushed a commit
to eddiebergman/automlbenchmark
that referenced
this pull request
Jul 21, 2023
* Remove commented out code * Specify mypy python version * Address mypy errors * Fix mypy errors * Fix mypy errors * Add type annotations * Add type checking requirements * Add ignore for [attr-defined], raised by normal Namespace use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a larger effort to improve developer experience (#566), I started adding
mypyto the dev tool chain.This PR adds a minimal configuration that checks as I am following the using mypy with an existing codebase recommendations.
This PR adds mypy only for
amlb.utils.The
mypyconfiguration globally ignores the "attr-defined" error, because of theamlb.utils.core.Namespaceclass which uses dynamically created attributes (technically not even that, but it is mimicked with__getattr__). I tried to narrow down the filtering of this error by just theNamespaceclass (either through configuration, or by redefiningNamespaceasAnyfor type checking purposes), but unfortunately I could not get that to work - so a global ignore it is. Reducing (or removing) the use ofNamespaceis something I'd like to refactor anyway, hopefully it will be enough so that we can remove the global ignore (possibly by adding specific line-level ignores if need be).