Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add open in browser function for each entity #433

Closed
mfeurer opened this issue Apr 4, 2018 · 1 comment · Fixed by #828
Closed

Add open in browser function for each entity #433

mfeurer opened this issue Apr 4, 2018 · 1 comment · Fixed by #828
Assignees
@PGijsbers
Labels
Good First Issue Issues suitable for people new to contributing to openml-python!

Comments

@mfeurer
Copy link
Collaborator

mfeurer commented Apr 4, 2018

To allow code like run.print_url() or run.open_in_browser().
@mfeurer mfeurer added the Good First Issue Issues suitable for people new to contributing to openml-python! label Apr 4, 2018
@PGijsbers
Copy link
Collaborator

Use the default library webbrowser.

@PGijsbers PGijsbers self-assigned this Oct 14, 2019
PGijsbers added a commit that referenced this issue Oct 16, 2019
@PGijsbers
Add #433 open_in_browser.
b799c39
@PGijsbers PGijsbers mentioned this issue Oct 17, 2019
Merged
mfeurer pushed a commit that referenced this issue Oct 17, 2019
@PGijsbers @mfeurer
Create OpenMLBase, have most OpenML objects derive from it (#828)
43596e0 
* Create OpenMLBase, have OpenMLFlow derive from it.

* Derive ID and entity_letter based on class type.

* Add #433 open_in_browser.

* Use OpenMLBase in Dataset, Run, Task.

* Use OpenMLBase for Study

* Update tag functions to take into account entity type.

* Quote OpenMLBase typing as it is only imported for type checking.

* Remove _repr_pretty_ as the default __repr__ prints pretty in a notebook anyway.

* Move _to_xml to base

* Fix bug, actually check for instance type to determine entity.

* Provide list to task type description in task __repr__

* Move fetching id to derived classes.

* Share base_url logic. Fix mypy warnings.

* Make child classes responsible for making sure _entity_letter is correct.

* Docstring and type hint changes.

* PEP8

* PEP8

* Fix mypy issues

* Fix CI mypy issues.

* Dont use Py3.6 syntax

* Fix CI mypy issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PGijsbers PGijsbers

Labels
Good First Issue Issues suitable for people new to contributing to openml-python!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create OpenMLBase, have most OpenML objects derive from it openml/openml-python
2 participants
@mfeurer @PGijsbers