Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sklearn 0.24 support #1016

Merged
merged 61 commits into from
Feb 11, 2021
Merged

Adding sklearn 0.24 support #1016

merged 61 commits into from
Feb 11, 2021

Conversation

Neeratyoy
Copy link
Contributor

What does this PR implement/fix? Explain your changes.

Adds support for sklearn 0.24, especially making example documentation support only this latest sklearn release.

How should this PR be tested?

Passing the new sklearn unit tests that will be spawned for sklearn 0.24 to run on Python 3.6 and higher.

Any other comments?

Main changes are wrt this feature added: scikit-learn/scikit-learn#17317

@Neeratyoy
Copy link
Contributor Author

@mfeurer
This unit test uses a flow which was built on sklearn=0.19 using from sklearn.ensemble.forest import RandomForestClassifier.
0.23 allows the import of this with a warning that 0.24 will only support from sklearn.ensemble import RandomForestClassifier and rightly so, this unit test fails for sklearn=0.24.

We can skip the unit test for sklearn=0.24, or allow the unit test by using a different flow? For the latter, can I pick any flow?

@Neeratyoy Neeratyoy marked this pull request as ready for review January 27, 2021 08:59
@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #1016 (0e44a0b) into develop (ab793a6) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1016      +/-   ##
===========================================
+ Coverage    88.04%   88.06%   +0.02%     
===========================================
  Files           36       36              
  Lines         4568     4568              
===========================================
+ Hits          4022     4023       +1     
+ Misses         546      545       -1     
Impacted Files Coverage Δ
openml/testing.py 84.14% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab793a6...0e44a0b. Read the comment docs.

Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but as I made a lot of changes myself, too, I'm also asking @PGijsbers to have a look at this.

Neeratyoy added a commit that referenced this pull request Feb 9, 2021
@PGijsbers PGijsbers merged commit d2945ba into develop Feb 11, 2021
@PGijsbers PGijsbers deleted the sklearn24-support branch February 11, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants