-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sklearn 0.24 support #1016
Conversation
@mfeurer We can skip the unit test for |
Codecov Report
@@ Coverage Diff @@
## develop #1016 +/- ##
===========================================
+ Coverage 88.04% 88.06% +0.02%
===========================================
Files 36 36
Lines 4568 4568
===========================================
+ Hits 4022 4023 +1
+ Misses 546 545 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, but as I made a lot of changes myself, too, I'm also asking @PGijsbers to have a look at this.
What does this PR implement/fix? Explain your changes.
Adds support for sklearn 0.24, especially making example documentation support only this latest sklearn release.
How should this PR be tested?
Passing the new sklearn unit tests that will be spawned for sklearn 0.24 to run on Python 3.6 and higher.
Any other comments?
Main changes are wrt this feature added: scikit-learn/scikit-learn#17317