Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run.py #1194

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Update run.py #1194

merged 3 commits into from
Feb 24, 2023

Conversation

v-parmar
Copy link
Contributor

@v-parmar v-parmar commented Feb 7, 2023

Reference Issue

Documentation Update #1069

What does this PR implement/fix? Explain your changes.

Here, I added a description for each attribute of what it represents.

Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contribution. This looks very helpful, unfortunately, it contains duplicate information. The type of each variable is now given twice: once in the type hint, and once in the documentation. Could you please update your PR to not contain such duplicate information?

@LennartPurucker
Copy link
Contributor

Heyho @v-parmar,

here is a potential version of what @mfeurer requested.
I also added the type hint for the default parameters.

You could update your PR/Commit with it if everyone thinks this is fine.

    """OpenML Run: result of running a model on an openml dataset.

    Parameters
    ----------
    task_id: int
        The ID of the OpenML task associated with the run.
    flow_id: int
        The ID of the OpenML flow associated with the run.
    dataset_id: int
        The ID of the OpenML dataset used for the run.
    setup_string: str, optional (default=None)
        The setup string of the run.
    output_files: Dict[str, str], optional (default=None)
        The map of file names to file locations. The files are related to the run.
    setup_id: int, optional (default=None)
        The ID of the setup used for the run.
    tags: List[str], optional (default=None)
        The tags associated with the run.
    uploader: int, optional (default=None)
        The user ID of the person who uploaded the run.
    uploader_name: str, optional (default=None)
       The name of the person who uploaded the run.
    evaluations: Dict, optional (default=None)
        The evaluations of the run.
    fold_evaluations: Dict, optional (default=None)
        The evaluations of the run for each fold.
    sample_evaluations: Dict, optional (default=None)
        The run for each sample.
    data_content: List[List], optional (default=None)
        The predictions generated from executing the run.
    trace: OpenMLRunTrace, optional (default=None)
        The trace of the run.
    model: object, optional (default=None)
        The model used to compute the run.
    task_type: str, optional (default=None)
        The type of the OpenML task associated with the run.
    task_evaluation_measure: str, optional (default=None)
        The evaluation measure used for the task.
    flow_name: str, optional (default=None)
        The name of the OpenML flow associated with the run.
    parameter_settings: List[OrderedDict], optional (default=None)
        The parameter settings of the model used for the run.
    predictions_url: str, optional (default=None)
        The URL of the predictions file on the server.
    task: OpenMLTask, optional (default=None)
        The OpenML task object associated with the run.
    flow: OpenMLFlow, optional (default=None)
        The OpenMLFlow object associated with the run.
    run_id: int, optional (default=None)
        The ID of the run.
    description_text: str, optional (default=None)
        The description to be added to the predictions file. If not provided, it is set to the time the arff file was generated.
    run_details: str, optional (default=None)
        Description of the run stored in the run meta-data.
    """

updated description to not contain duplicate information.
@LennartPurucker
Copy link
Contributor

Hey @v-parmar,

Thank you very much for the update. But I think you only updated some of it. @mfeurer specifically wanted to change the duplicate information. These duplicates still exist in the current version.

If you compare my version from above and the current version, it is mainly about the start of the parameters' descriptions, which usually start with explaining the type. As far as I can tell, this was the problem.

@v-parmar
Copy link
Contributor Author

Hey @mfeurer, as you said I have updated the description and removed duplicate information. @LennartPurucker Thanks for the hint.

@mfeurer mfeurer merged commit 5dcb7a3 into openml:develop Feb 24, 2023
mfeurer added a commit that referenced this pull request Mar 1, 2023
* added additional task agnostic local result to print of run

* add PR to progress.rst

* fix comment typo

* Update openml/runs/run.py

Co-authored-by: Matthias Feurer <lists@matthiasfeurer.de>

* add a function to list available estimation procedures

* refactor print to only work for supported task types and local measures

* add test for pint out and update progress

* added additional task agnostic local result to print of run

* add PR to progress.rst

* fix comment typo

* Update openml/runs/run.py

Co-authored-by: Matthias Feurer <lists@matthiasfeurer.de>

* add a function to list available estimation procedures

* refactor print to only work for supported task types and local measures

* add test for pint out and update progress

* Fix CI Python 3.6 (#1218)

* Try Ubunte 20.04 for Python 3.6

* use old ubuntu for python 3.6

* Bump docker/setup-buildx-action from 1 to 2 (#1221)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1 to 2.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v1...v2)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update run.py (#1194)

* Update run.py

* Update run.py

updated description to not contain duplicate information.

* Update run.py

* add type hint for new function

* update add description

* Refactor if-statements (#1219)

* Refactor if-statements

* Add explicit names to conditional expression

* Add 'dependencies' to better mimic OpenMLFlow

* Ci python 38 (#1220)

* Install custom numpy version for specific combination of Python3.8 and numpy

* Debug output

* Change syntax

* move to coverage action v3

* Remove test output

* added additional task agnostic local result to print of run

* add PR to progress.rst

* fix comment typo

* Update openml/runs/run.py

Co-authored-by: Matthias Feurer <lists@matthiasfeurer.de>

* add a function to list available estimation procedures

* refactor print to only work for supported task types and local measures

* add test for pint out and update progress

* added additional task agnostic local result to print of run

* add PR to progress.rst

* add type hint for new function

* update add description

* fix run doc string

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matthias Feurer <lists@matthiasfeurer.de>
Co-authored-by: Matthias Feurer <feurerm@informatik.uni-freiburg.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vishal Parmar <vishalm524112@gmail.com>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants