Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1349 #1350

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Fix/1349 #1350

merged 4 commits into from
Sep 16, 2024

Conversation

PGijsbers
Copy link
Collaborator

Closes #1349

Distutils is removed in Py3.12, so we have to rely on external packages.
packaging is already a dependency of one of our dependencies, so it doesn't add to the stack (though I made it implicit, in case the dependency chain gets broken at some point for some reason).

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.14%. Comparing base (de983ac) to head (d84249b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
openml/extensions/sklearn/extension.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1350      +/-   ##
===========================================
+ Coverage    83.88%   84.14%   +0.26%     
===========================================
  Files           38       38              
  Lines         5261     5260       -1     
===========================================
+ Hits          4413     4426      +13     
+ Misses         848      834      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PGijsbers PGijsbers marked this pull request as ready for review September 13, 2024 12:04
@PGijsbers
Copy link
Collaborator Author

There are unfortunately minor server issues after all. They didn't happen earlier in the week in a local test, currently don't have the internet connection bandwidth to track it down (travelling). But looking at the failures, they can't be related to the PR.

@eddiebergman
Copy link
Collaborator

Not super familiar with this domain of Python but from a quick read it seems mostly superficial in terms of changes and didn't spot anything off

@PGijsbers PGijsbers merged commit fa7e9db into develop Sep 16, 2024
11 of 14 checks passed
@PGijsbers PGijsbers deleted the fix/1349 branch September 16, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop relying on distutils for Py3.12 compatibility
3 participants