fix: workaround for git test workflow for Python 3.8 #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1369 +/- ##
===========================================
- Coverage 84.07% 84.05% -0.02%
===========================================
Files 38 38
Lines 5305 5301 -4
===========================================
- Hits 4460 4456 -4
Misses 845 845 ☔ View full report in Codecov by Sentry. |
|
The previous point is still the root cause but the fix did not work. Thus, we now skip it in the workflow for 3.8. |
LennartPurucker
commented
Oct 16, 2024
| @@ -115,7 +115,7 @@ def tearDown(self) -> None: | |||
| """Tear down the test""" | |||
| os.chdir(self.cwd) | |||
| try: | |||
| shutil.rmtree(self.workdir, ignore_errors=True) | |||
There was a problem hiding this comment.
I introduced this in another PR to fix this issue but it did not help. Hence, I removed it here again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Python 3.8 tests kept failing due to temporary files not being deleted in our pytest setup.
This was because, for some unexplainable reason, oslo concurrency lock files were created after a pytest fixture closed. This pytext fixture was used in a parameterized pytest and even deleted the lock file itself. However, the lock files were re-created after the fixture finished.
As this only affects our git workflow and only for Python 3.8, I added a skip to the test that causes this problem, as far as I know.