Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github workflows and pytest issue #1373

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

LennartPurucker
Copy link
Contributor

This fixes three things:

  1. First, when pushing to develop, the CI will not fail if we do not need to update the gh docs.
  2. Second, it rolls back a previous change to the workflow that did not fix an issue.
  3. We fix the original issue by removing leftover dirs.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (8fbf39e) to head (d2bb5d3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1373      +/-   ##
===========================================
+ Coverage    84.17%   84.31%   +0.13%     
===========================================
  Files           38       38              
  Lines         5303     5303              
===========================================
+ Hits          4464     4471       +7     
+ Misses         839      832       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gpt enshitification has encroached further, plunging us further into the demise of deep dark despairs. The light has faded, shadow has gained and the sky weeps a woeful tear upon this dry earth. however... LGTM 🚀 !

@eddiebergman eddiebergman merged commit 26ae499 into develop Oct 17, 2024
13 checks passed
@eddiebergman eddiebergman deleted the fix/doc_workflow branch October 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants