Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username #790

Merged
merged 11 commits into from
Oct 1, 2019
Merged

Add username #790

merged 11 commits into from
Oct 1, 2019

Conversation

sahithyaravi
Copy link
Member

Reference Issue

What does this PR implement/fix? Explain your changes.

Add uploader and id columns to list_evaluations

How should this PR be tested?

evaluations = openml.evaluations.list_evaluations("predictive_accuracy",
uploader=[uploader_id],
output_format='dataframe')

Any other comments?

@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #790 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #790      +/-   ##
===========================================
- Coverage    87.69%   87.69%   -0.01%     
===========================================
  Files           36       36              
  Lines         4201     4208       +7     
===========================================
+ Hits          3684     3690       +6     
- Misses         517      518       +1
Impacted Files Coverage Δ
openml/evaluations/functions.py 92% <100%> (+0.42%) ⬆️
openml/evaluations/evaluation.py 64.28% <100%> (+2.74%) ⬆️
openml/_api_calls.py 83.11% <0%> (-1.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e03906...06cf639. Read the comment docs.

Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks really helpful.

I only have one minor request and one question.

openml/evaluations/evaluation.py Outdated Show resolved Hide resolved
openml/evaluations/functions.py Outdated Show resolved Hide resolved
@mfeurer mfeurer merged commit f461732 into develop Oct 1, 2019
@mfeurer mfeurer deleted the add_username_id branch October 1, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants