Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional part of OpenML error message to exception message #811

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Oct 11, 2019

This allows us to see the error message given by OpenML to simplify debugging.

@PGijsbers PGijsbers self-requested a review October 14, 2019 09:02
@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #811 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #811      +/-   ##
===========================================
+ Coverage    87.69%   87.71%   +0.02%     
===========================================
  Files           36       36              
  Lines         4234     4234              
===========================================
+ Hits          3713     3714       +1     
+ Misses         521      520       -1
Impacted Files Coverage Δ
openml/_api_calls.py 84.61% <100%> (+1.49%) ⬆️
openml/exceptions.py 93.54% <100%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e85bb6...94edba9. Read the comment docs.

@PGijsbers
Copy link
Collaborator

It looks like this unit test still refers to the now-missing attribute. Please update and do a quick search through all files to see if there is other code attempting to directly set the attribute.

@PGijsbers PGijsbers merged commit 9467ed4 into develop Oct 14, 2019
@PGijsbers PGijsbers deleted the update_error_handling branch October 14, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants