Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't warn if we can convert to dataframe #829

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

amueller
Copy link
Contributor

Right now there are a lot of "can't convert non-sparse dataframe to dataframe" warnings.

I don't think those make sense. Here I'm converting to dataframe. I'm not sure if that's actually necessary. We might know that it's a dataframe here already?

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@23d4e6f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #829   +/-   ##
==========================================
  Coverage           ?   88.05%           
==========================================
  Files              ?       36           
  Lines              ?     4246           
  Branches           ?        0           
==========================================
  Hits               ?     3739           
  Misses             ?      507           
  Partials           ?        0
Impacted Files Coverage Δ
openml/datasets/dataset.py 87.56% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d4e6f...160e880. Read the comment docs.

@mfeurer mfeurer merged commit 29a023c into openml:develop Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants