-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork api #937
Closed
Closed
Fork api #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [28cab4e3] edit dataset changes and example
# Conflicts: # examples/30_extended/datasets_tutorial.py # openml/datasets/functions.py # tests/test_datasets/test_dataset_functions.py
Squashed commits: [55778ad] fix test
…to edit_api # Conflicts: # examples/30_extended/datasets_tutorial.py
Codecov Report
@@ Coverage Diff @@
## develop #937 +/- ##
========================================
Coverage 87.76% 87.76%
========================================
Files 37 37
Lines 4429 4446 +17
========================================
+ Hits 3887 3902 +15
- Misses 542 544 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#929
What does this PR implement/fix? Explain your changes.
Fork API to clone a dataset.
How should this PR be tested?
Any other comments?
For the testing, I have just compared the did. Ideally we want to check if the cloned data==old data and cloned features == old features. But the time taken for the status of the dataset to change to active varies (may be 1 min).
time.sleep(60) should work most of the time, but I am not sure if the tests may fail at some point.
Let me know if it is a good idea to add this to the test. Something like: