Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHARMM migration from openmm #1

Merged
merged 2 commits into from
Mar 23, 2017
Merged

CHARMM migration from openmm #1

merged 2 commits into from
Mar 23, 2017

Conversation

ChayaSt
Copy link
Contributor

@ChayaSt ChayaSt commented Mar 1, 2017

Migrating openmm/openmm#1542

@ChayaSt
Copy link
Contributor Author

ChayaSt commented Mar 1, 2017

What's currently left to do is add the ability to write out the <patch> field in parmed.

How patches are implemented in openmm
The main issue with writing out the patches in parmed is that the documentation in the CHARMM files are not consistent.

@jchodera
Copy link
Member

jchodera commented Mar 1, 2017

@ChayaSt : Could you fix that link and elaborate a bit more? Does ParmEd load the CHARMM PATChes, but doesn't yet write those out when writing OpenMM ffxml files?

@ChayaSt
Copy link
Contributor Author

ChayaSt commented Mar 1, 2017

Yes, ParmEd loads the patches, but I don't think it loads which residues it can be applied too which is what's needed for the <patch> field.

In the CHARMM files, the patch usually has some comments about where the patches should be applied (but not always). Sometimes it doesn't name the residue it should be patched too with the CHARMM residue name. See this example

Sometimes it does name the residue correctly. See here

@jchodera
Copy link
Member

@ChayaSt : Let's go ahead and merge this. We can clean things up in subsequent PRs.

@ChayaSt ChayaSt merged commit 98e57c3 into openmm:master Mar 23, 2017
@jchodera jchodera mentioned this pull request Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants