Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/camera mode api #672

Draft
wants to merge 129 commits into
base: main
Choose a base branch
from
Draft

Feature/camera mode api #672

wants to merge 129 commits into from

Conversation

maerki
Copy link
Contributor

@maerki maerki commented Jan 8, 2025

No description provided.

maerki and others added 30 commits August 26, 2024 09:25
@maerki
Improve setT handling
bc8051d
@maerki
update tile loading logic
545b20b 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@simonroesch
load only 10 tiles in parallel to make sure the most important tiles …
5d95aef 
…are loaded fast
@simonroesch
fix mailbox memberFn hashing
05935b2
@simonroesch
add dataMutex lock for Polygon2dOpenGl drawPolygon
6b4290f
@simonroesch
improvements for time travel loading
30435dc
@maerki
setup animated dashes
99f1957 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@maerki
correct parameter handling
99345b9 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@zimmermannubique
adds arrayValue
1fb66a3
@maerki
allow dotted line
2883d8c 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@maerki
fix vector line style
fd35aea 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@maerki
Merge pull request #662 from openmobilemaps/feature/animated-dashes
36da387 
Feature/animated dashes
@maerki
fix retry delay computation
c29d112 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@maerki
improve time property
d61205a 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@maerki
Merge branch 'main' into develop
d0c8609
@maerki
Add missing line fixes
6297567 
Fix mixup after  fd35aea.

Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@maerki
only render what’s visible
47578ee 
Signed-off-by: Nicolas Märki <maerki@ubique.ch>
@matzf
WIP: cmake build, maven pom, dummy code
6d27475
@matzf
test code draws something
5cd7cbd
@matzf
Use OSMesa in Java, hacky fix for JNI dep in core
b5edf34
@matzf
Add DataLoader and TextureHolder, somewhat working
443fa75 
Small fixes, e.g. avoid crashing on missing font results.

Use small JNI function to load textures, instead of depending on a
full-blown GL framework for Java. Somewhat simplistic and not optimized,
but probably good enough.

DataLoader uses java http client which is a bit bare-bones. Might have
to be made more tweakable.
@matzf
Add fonts
a802b71 
The font fallback is just there for my own benefit, not sure if this is
going to be good/bad.
@matzf
Various cleanup
0dfc77c
@matzf
Add map tiler and offscreen renderer abstractions
4a106f3
@matzf
Remove misc debug printf
57bc63f
@matzf
Add multisample anti-aliasing support
914bb3a
@matzf
Fix cleanup of FBO/RBO in OSMesa helper
a2bd7d3
@matzf
build: include platform string in native library filename
6b0273b 
Name suffix is linux_amd64 (plus _debug for debug build).
@matzf
WIP
86a5ee0
@matzf
Reformat java and fix various warnings
0cd4f02
eeppee-admin and others added 10 commits January 3, 2025 17:00
@eeppee-admin
Update readme.md
5ed96ea
@maurhofer-ubique
Add interface for and implementations of a generic performance logger…
da87b14 
… (CPU and OpenGL)
@maurhofer-ubique
Merge pull request #668 from eeppee-admin/patch-1
093e50c 
Update readme.md
@maurhofer-ubique
Move OpenGlPerformanceLoggerInterface and add non-OpenGL stub
1cd0ab9
@maurhofer-ubique
Merge pull request #666 from openmobilemaps/feature/feature-dependent…
ebff3a3 
…-text-fonts

Feature Dependent Text Fonts
@maurhofer-ubique
Adjust ChronoUtil include
1d252ea
@maurhofer-ubique
Adjust includes for GenericPerformanceLogger, adjust CMakeLists.txt f…
7cccfdc 
…or JVM Build
@maurhofer-ubique
Merge pull request #670 from openmobilemaps/feature/performance-logger
c0c4a68 
Add interface for and implementations of a generic performance logger (CPU and OpenGL)
@maerki
add camera mode again for convenience,
7658ec3
@maerki
better error message for missing shaders
78934c1
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Base automatically changed from release/3.0.0-rc.4 to main January 10, 2025 13:23
maurhofer-ubique and others added 10 commits January 13, 2025 09:40
@maurhofer-ubique
Add specific levels option for vector layer style jsons
8a523bf
@maurhofer-ubique
Fix map entry check in logger
8e1f45b
@stmitt
implements icon on line placement and text on line offset calculation
332d1b8
@maurhofer-ubique
Merge pull request #676 from openmobilemaps/feature/icon-line-placement
44212fc 
Feature: icon line placement
@stmitt
only set blend mode async if really needed
fba5ee3 
otherwise it can happen that the first few frames of a object are in the wrong blend mode
@maurhofer-ubique
Add line selection scale factor
65c802e
@stmitt
Merge remote-tracking branch 'origin/main' into develop
d0f0744 
# Conflicts:
#	ios/graphics/Shader/Metal/LineShader.metal
#	shared/src/map/layers/tiled/vector/symbol/Tiled2dMapVectorSymbolGroup.cpp
#	shared/src/map/layers/tiled/vector/symbol/Tiled2dMapVectorSymbolGroup.h
@stmitt
lock the mailbox of the vector layer actor after creating it
22ca73e 
this fixes a random crash when generating the renderpasses
@maurhofer-ubique
Merge pull request #678 from openmobilemaps/bugfix/lock-mailbox
2a226b0 
Lock the mailbox of the vector layer actor after creating it
@stmitt
Merge branch 'develop' into feature/camera-mode-api
2e6f3c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmitt stmitt Awaiting requested review from stmitt

@maurhofer-ubique maurhofer-ubique Awaiting requested review from maurhofer-ubique

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maerki @simonroesch @zimmermannubique @matzf @stmitt @maurhofer-ubique @eeppee-admin