Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema cleanup #204

Closed
wants to merge 3 commits into from
Closed

Schema cleanup #204

wants to merge 3 commits into from

Conversation

hunterowens
Copy link
Collaborator

This PR renames generate_schema to schema, and removes the Pipfile, because we have a requirements.txt

@thekaveman
Copy link
Collaborator

I like the cleanup idea; part of the reason for the verbose directory naming was so that this directory was not confused as containing the actual schemas, which are in the provider directory.

However with work on #203 and discussions in #95 and #157, I think it makes sense to have a dedicated schema directory, perhaps with code and schema files alike?

Maybe create an additional subdirectory schema/generate, with existing code renamed to provider.py, and the existing .json moved in (as they are really schema partials/templates). Then we can generate the actual schemas into the root of the schema directory or sub-directories as outlined in #95.

Alternatively, leave the python alone and create a schema/templates or similar subdirectory for the existing .json? So they are not confused as the actual schemas.

@hunterowens hunterowens added this to the 0.3.0 milestone Jan 24, 2019
@hunterowens hunterowens modified the milestones: 0.3.0, 0.3.1 Feb 12, 2019
@hunterowens hunterowens modified the milestones: 0.3.1, 0.3.2 Apr 29, 2019
@hunterowens hunterowens mentioned this pull request Jun 7, 2019
@hunterowens
Copy link
Collaborator Author

closing in favor of #328

@hunterowens hunterowens closed this Jun 8, 2019
@hunterowens hunterowens deleted the schema-cleanup branch June 28, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants