Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial MDS Metrics definitions #487

Merged
merged 8 commits into from
Oct 16, 2020
Merged

Add initial MDS Metrics definitions #487

merged 8 commits into from
Oct 16, 2020

Conversation

whereissean
Copy link
Contributor

MDS Pull Request

Explain pull request

This PR represents a proposal for initial MDS core and dockless metrics related to and retrieved by #486.

Is this a breaking change

  • No, not breaking

Impacted Spec

  • agency
  • provider

Additional context

This PR is related to the MDS Metrics Issue #485.

@whereissean whereissean requested a review from a team as a code owner April 27, 2020 19:07
@whereissean whereissean mentioned this pull request Apr 27, 2020
Closed
@schnuerle schnuerle added this to the 1.1.0 milestone Jun 9, 2020
@jfh01 jfh01 mentioned this pull request Jul 17, 2020
Closed
@schnuerle schnuerle linked an issue Aug 13, 2020 that may be closed by this pull request
Add an MDS Metrics API #485
Closed
@schnuerle schnuerle added the Metrics Related to the Metrics API and related topics label Aug 28, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@schnuerle schnuerle changed the base branch from dev to feature-metrics October 12, 2020 22:44
@schnuerle
Copy link
Member

Note that for 1.1.0 we have merged with #582 the new Geography API to the 'dev' branch. Please update this pull request with the latest code, resolve any conflicts, and make references to the Geography API where appropriate, e.g. with UUIDs.

We will be discussing Metrics at this week's Working Group meeting, so if available please come prepared to talk about your latest updates and ideas.

I've made a feature branch called 'feature-metrics' to start pulling all the Metrics related work together and do PRs against. Updated this PR to point to that instead of 'dev'.

@schnuerle schnuerle added the privacy Implications around privacy for the attention of the OMF Privacy Committee label Oct 13, 2020
@schnuerle
Copy link
Member

@joanathan thanks for the latest commit. Make sure to grab the current 'dev' branch code, resolve conflicts, and incorporate the changes new with Geography. That would make Metrics the 5th API.

@schnuerle schnuerle mentioned this pull request Oct 16, 2020
Closed
schnuerle
schnuerle approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I've closed #486 and will use this PR for the feature branch.

metrics/README.md Show resolved Hide resolved
@schnuerle schnuerle merged commit bf03a8d into openmobilityfoundation:feature-metrics Oct 16, 2020
This was referenced Oct 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schnuerle schnuerle schnuerle approved these changes

Assignees
No one assigned
Labels
Metrics Related to the Metrics API and related topics privacy Implications around privacy for the attention of the OMF Privacy Committee
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Add an MDS Metrics API
4 participants
@whereissean @CLAassistant @schnuerle @joanathan