Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Unknown/Unspecified State Transitions #558

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Updated Unknown/Unspecified State Transitions #558

merged 1 commit into from
Jul 30, 2020

Conversation

janedotx
Copy link
Contributor

No description provided.

@janedotx janedotx requested a review from a team as a code owner July 30, 2020 15:23
@thekaveman
Copy link
Collaborator

thekaveman commented Jul 30, 2020 •
edited
Loading

Would you please give a little more context to these changes? Is there an issue discussing the need for these updates? Are there corresponding updates that need to be made to the schema?

EDIT: Spoke with @schnuerle who has been doing a review of the state machine. Thanks for these updates @janedotx!

@schnuerle schnuerle mentioned this pull request Jul 30, 2020
Closed
@schnuerle schnuerle linked an issue Jul 30, 2020 that may be closed by this pull request
Issues with State Machine Diagram and Table #559
Closed
@schnuerle schnuerle added bug Something isn't working Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram labels Jul 30, 2020
@schnuerle schnuerle added this to the 1.0.0 milestone Jul 30, 2020
@schnuerle schnuerle marked this pull request as draft July 30, 2020 18:20
@schnuerle schnuerle marked this pull request as ready for review July 30, 2020 19:37
@schnuerle
Copy link
Member

Reviewed and the changes made look good based on agreed upon changes from our conversations. Thank you!

@schnuerle schnuerle merged commit 375c17d into openmobilityfoundation:release-1.0.0 Jul 30, 2020
@schnuerle schnuerle changed the title Updated state transitions. Updated Unknown/Unspecified State Transitions Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Issues with State Machine Diagram and Table
3 participants
@janedotx @thekaveman @schnuerle