Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional geography types (per #580) #581

Conversation

marie-x
Copy link
Collaborator

@marie-x marie-x commented Sep 29, 2020

Explain pull request

See #580

Is this a breaking change

  • No

Impacted Spec

Which spec(s) will this pull request impact?

  • geography

Additional context

None at moment

@marie-x marie-x requested a review from a team as a code owner September 29, 2020 17:44
@marie-x marie-x changed the title Add geography types optional (per #580) Add optional geography types (per #580) Sep 30, 2020
@schnuerle schnuerle linked an issue Sep 30, 2020 that may be closed by this pull request
@schnuerle schnuerle added the Geography Items related to the Geography API label Sep 30, 2020
@schnuerle
Copy link
Member

Because there were conflicts, I made the changes manually in this commit.

It's the same, except I added a few more types.

Please review and we can close this PR.

@schnuerle schnuerle added this to the 1.1.0 milestone Oct 8, 2020
@schnuerle
Copy link
Member

Added in #582.

@schnuerle schnuerle closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Geography Items related to the Geography API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional geography_type field to Geography spec
2 participants