Rename publish_date to published_date for a geography object

[fractalf]

A policy object contains a property published_date which is the exact
same thing as a geography object's publish_date. These should therefore
also have the same name to prevent errors and confusion.

---

name: Default
about: Suggest changes to MDS
title: Rename publish_date to published_date for a geography object

---

MDS Pull Request

Thank you for your contribution! Please review our OMF contributing page to understand guidelines and policies for participation, and our Code of Conduct page.

To avoid complications and help make the Review process as smooth as possible, make sure to:

1. Target dev branch. Please ensure you are targeting dev, not main.
2. Keep the "Allow edits from maintainers" button checked to help us resolve some issues for you.
3. Be ready to resolve any merge conflicts before we approve your Pull Request.
4. Have an up to date profile, per our Github community profile guildance.

Explain pull request

A policy object contains a property published_date which is the exact
same thing as a geography object's publish_date. These should therefore
also have the same name to prevent errors and confusion.

Is this a breaking change

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

• Yes, breaking

Impacted Spec

Which spec(s) will this pull request impact?

• policy

Additional context

[CLAassistant]

All committers have signed the CLA.

[schnuerle]

Added some tags and slated for 2.0.0 release since changing the field names. However since this looks like only Geography is being changed, and that hasn't released yet, maybe it can be in 1.1.0.

Also @fractalf make sure to sign the CLA.

[fractalf]

@schnuerle
CLA signed

I have limited knownledge to the structure/branches of this project, I just followed the instructions and edited the dev branch.
If the dev branch is targetet for 2.0.0 then I understand.

If you feel this change could be in 1.1.0, I'm happy to make another PR, but the I need to know where to put it? I saw no branch targeting 1.1.0

[schnuerle]

Thanks for signing.

There is no branch for releases until the OMF makes a release candidate. Everything pretty much gets pointed to 'dev' like you have done already, before going to OMF tech council and board for release approval. The Milestone tags help categorize features and PRs for releases until they are ready. So you are doing things right!

This whole PR can go into 1.1.0, except for the geography field name change within policy, per our conversation here, since that would be breaking. So I went in and edited that away for now.

[schnuerle]

Good for 1.1.0 changes to the new geography endpoint.