Replace unknown state #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced 'unknown' with 'non-contactable' and 'missing' in the Vehicles States table to be clearer about the transition from Yes PROW -> No PROW as discussed in openmobilityfoundation#749. Changed explanatory paragraph on 'unknown' to instead describe use of 'non-contactable' and 'missing'. Open Question: should MDS recommend a specific time limit for the transition from 'non-contactable' to 'missing' if the city does not have an SLA around this?
Changed 'missing' to 'not_located' since there's a new vehicle state for 'missing'. Clarified 'located' to match. See openmobilityfoundation#749 (comment)
Replaced 'unknown' state with new 'non_contactable' along with associated event types in the transitions. Note: event types included 'located' and 'missing' but this isn't in the transitions table. If they are to be included then need to add 'missing' vehicle state and modify event type to 'not_located'.
Replaced 'unknown' state with new 'non_contactable' along with associated event types in the transitions.
Replaced 'unknown' state with new 'non_contactable' along with associated event types in the transitions.
Replaced 'unknown' state with new 'non_contactable' and 'missing' along with associated event types in the transitions.
Updated transitions so that only 'non_contactable' -> 'missing', but 'missing' -> any state
Added Missing state and transitions. Cleaned up some other transitions where noticed dupes or missing.
|
|
schnuerle
added
Provider
Updated micromobility state diagram to remove 'unknown' state and replace with 'non-contactable' and 'missing' states
|
I'm going to merge to dev and hopefully any issues with this tedious work will come out during the release candidate review. Also a note to me to update the micromobility SVG file and point to it when doing that state machine work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Replace unknown state
about: Replace unknown state with two new states so that vehicles can definitely be yes/no in PROW.
title: Replace unknown state
MDS Pull Request
Thank you for your contribution! Please review our OMF contributing page to understand guidelines and policies for participation, and our Code of Conduct page.
To avoid complications and help make the Review process as smooth as possible, make sure to:
devbranch. Please ensure you are targetingdev, notmain.Explain pull request
Replacing
unknownstate which is maybe PROW with new states -non_contactablewhich is yes PROW, andmissingwhich is no PROW.Is this a breaking change
A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).
Impacted Spec
Which spec(s) will this pull request impact?
agencypolicyproviderAdditional context
Issue was discussed in multiple MDS Planning meetings. PR was created based on this proposal - #749 (comment).
Still open is whether MDS wants to recommend a transition time limit from
non-contactabletomissing state.