(fix) Fix docstring for extractVariableNames (#1178)

openmrs · Oct 15, 2024 · 7c04405 · 7c04405
1 parent 7696397
commit 7c04405
Show file tree

Hide file tree

Showing 3 changed files with 81 additions and 68 deletions.
diff --git a/packages/apps/esm-login-app/translations/en.json b/packages/apps/esm-login-app/translations/en.json
@@ -8,6 +8,7 @@
   "confirmPassword": "Confirm new password",
   "continue": "Continue",
   "errorChangingPassword": "Error changing password",
+  "footerlogo": "Footer Logo",
   "invalidCredentials": "Invalid username or password",
   "locationPreferenceRemoved": "Login location preference removed",
   "locationPreferenceRemovedMessage": "You will need to select a location on each login",

diff --git a/packages/framework/esm-expression-evaluator/src/extractor.ts b/packages/framework/esm-expression-evaluator/src/extractor.ts
@@ -35,6 +35,7 @@ import { globalsAsync } from './globals';
  * ```ts
  * // variables will be ['myVar']
  * const  variables = extractVariableNames('new String(myVar)')
+ * ```
  *
  * Note that because this expression evaluator uses a restricted definition of "global" there are some Javascript
  * globals that will be reported as a unbound expression. This is expected because the evaluator will still fail