-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) O3-4011 - add mock for PatientBannerPatientIdentifier #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
requested review from
mseaton,
brandones,
mogoodrich,
denniskigen and
ibacher
October 16, 2024 20:28
Size Change: -21.6 kB (-0.35%) Total Size: 6.12 MB
ℹ️ View Unchanged
|
mseaton
reviewed
Oct 16, 2024
@@ -75,6 +75,7 @@ export const CustomOverflowMenu = jest.fn(({ menuTitle, children }) => ( | |||
export const PatientBannerActionsMenu = jest.fn(() => <div>Patient Banner Actions Menu</div>); | |||
export const PatientBannerContactDetails = jest.fn(() => <div>Patient Banner Contact Details</div>); | |||
export const PatientBannerPatientInfo = jest.fn(() => <div>Patient Banner Patient Info</div>); | |||
export const PatientBannerPatientIdentifier = jest.fn(() => <div>Patient Banner Patient Info</div>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it say something different than the one above it?
Also, minor detail - the conventional commit label in the PR title for this change should be |
chibongho
changed the title
(chore) O3-4011 - add mock for PatientBannerPatientIdentifier
(test) O3-4011 - add mock for PatientBannerPatientIdentifier
Oct 16, 2024
Thanks... fixed. |
denniskigen
approved these changes
Oct 16, 2024
mogoodrich
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
forgot to add mock in my earlier PR.
Screenshots
Related Issue
Other