Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) update github actions prerelease template to use yarn #11

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

mogoodrich
Copy link
Member

No description provided.

@@ -0,0 +1,2 @@
node_modules/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When updating the Dispensing module to use yarn to publish instead of npm I discovered I had to add this file because of this issue:

yarnpkg/yarn#754

Please feel free to rework if there's a better way to do this... I noticed that some of the other ESM projects are using different commands when publishing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, if we migrate to a newer version of Yarn it's a non-issue. The monorepos are using all using Lerna (albeit an older version) to publish.

@ibacher ibacher merged commit a5a1b2f into main Sep 16, 2022
@ibacher ibacher deleted the github-actions-prerelease-update branch September 16, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants