-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete issues. #33
base: master
Are you sure you want to change the base?
Complete issues. #33
Conversation
I changed the parameter name of the function: Since the feature was added quite recently, I doubt that it will cause any serious problems for users. |
Changing parameter names in natives doesn't make any difference. Annoyingly it does in I also wondering if |
There's a doc for GetPlayerAnimationFlags #define ANIM_FREEZE_FLAG 0b0000000000000100
#define ANIM_LOCK_X_FLAG 0b0010000000000
#define ANIM_LOCK_Y_FLAG 0b0001000000000
#define ANIM_LOOP_FLAG 0b0000100000000 |
Probably just use hex like most other numbers, but otherwise yes that's what I meant by the enum comment. |
I added a return tag for |
Complete issues
Details
The
GetPlayerAnimationFlags
function is a duplicate of theGetPlayerAnimFlags
function and I'm thinking about whether it should be labelled as such:Or should it not be done?
It's not done at the moment.
Additionally: