Convert msec to sec for ECAT to BIDS json #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bilgelm please bump version to 1.2.X +1 in |
|
Bumped version to 1.2.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various ECAT entries are in msec, including several frame time entries. These need to be converted to seconds to be compatible with PET-BIDS. The python implementation currently doesn't check the time unit, resulting in msec values in the json.
This PR determines which ECAT entries are in msec by looking at the "comment" field in
ecat_headers.jsonand converts their values to seconds.Verified that the conversion works for the ECAT v7.0 example included in the repo and for ECAT v7.3. Will add this ECAT v7.3 phantom data to the Google folder.