fix: clientContext isn't available in background functions #2121
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| const { | ||
| clientContext: { custom: customContext }, | ||
| } = context | ||
| const customContext = context.clientContext?.custom |
There was a problem hiding this comment.
Do we have any way to test this @Skn0tt?
I appreciate we might not have a good testing strategy yet for this.
There was a problem hiding this comment.
I don't think we have a good testing strategy yet, no. We could probably build something to test background functions using https://webhook.site/, but i'd like to address that in a separate PR/issue.
There was a problem hiding this comment.
I've tested this manually and it works fine. As @Skn0tt mentioned, we definitely need e2e testing around background functions, but it feels separate to this fix.
There was a problem hiding this comment.
Tracked the need for an E2E test in #2122.
| const { | ||
| clientContext: { custom: customContext }, | ||
| } = context | ||
| const customContext = context.clientContext?.custom |
There was a problem hiding this comment.
I've tested this manually and it works fine. As @Skn0tt mentioned, we definitely need e2e testing around background functions, but it feels separate to this fix.
kodiakhq
bot
deleted the
fix-clientcontext-not-available-in-background-functions
branch
Description
This PR fixes a regression introduced in #2058.
clientContextisn't available in backround functions, so destructuring on it throws an error.Documentation
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal