Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing out of date schema editing guidance #76

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Removing out of date schema editing guidance #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39383ae
Removing out of date schema editing guidance
kd-ods Apr 27, 2022
b8f0ebe
Reverting some changes
Blueskies00 Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,9 @@ ie. To update the `libcovebods/data/schema-0-2-0.json` file, check out `0.2.0`
Run the compile tool, telling it where the codelists directory is and pipe the output to the file for the version
you have checked out:

compiletojsonschema -c openownership-data-standard/schema/codelists/ openownership-data-standard/schema/bods-package.json > openownership-lib-cove-bods/libcovebods/data/schema-0-2-0.json
compiletojsonschema -c openownership-data-standard/schema/codelists/ openownership-data-standard/schema/bods-package.json > openownership-lib-cove-bods/libcovebods/data/schema-0-2-0.json

Due to https://github.com/openownership/data-standard/issues/375 you may have to do some editing by hand. Open the files
in `libcovebods/data`. At the top level there is an `oneOf` with 3 statement types - people, entity, and ownershipOrControl.
In each of these statement types, there is an enum for the `statementType` field. This enum should have one option only -
the value for whatever type of statement it is. (ie The person statement should only have the `personStatement` value)
This tool may have added extra options - if so, remove them by hand.
Due to https://github.com/openownership/data-standard/issues/375 you may have to do some editing by hand when using early versions of the schema, pre 0.3. Open the files in `libcovebods/data`. At the top level there is an `oneOf` with 3 statement types - people, entity, and ownershipOrControl. In each of these statement types, there is an enum for the `statementType` field. This enum should have one option only - the value for whatever type of statement it is. (ie The person statement should only have the `personStatement` value). This tool may have added extra options - if so, remove them by hand.

## Code for use by external users

Expand Down