Use '--psm' instead of '-psm' as the option was deprecated.

[ddddavidmartin]

This recently changed in the official tesseract engine [0]. -psm is not allowed as an option anymore and --psm has to be used instead.

This fixes #99.

Thanks!

[0] tesseract-ocr/tesseract@ee201e1

[jflesch]

Not so simple, unfortunately.

With Tesseract 3.03:

$ tesseract --psm 9
Tesseract Open Source OCR Engine v3.03 with Leptonica
Cannot open input file: --psm

AFAIK, Tesseract 4 is still not stable (and not available in Debian stable anyway). Therefore support for all versions of Tesseract > 3 must be maintained.
The best way to work around that problem would be to call get_version() and decide what to do based on the version of Tesseract. Similar fixes already exist in can_detect_orientation() and detect_orientation().

[ddddavidmartin]

Ah yes, that makes sense. I shall have a look and update the pull request. Thanks for checking!

[jflesch]

You could have used Python ternary operator: return "--psm" if version[0] > 3 else "-psm"

[ddddavidmartin]

Fixed this in the updated pull request.

[jflesch]

Thanks :)

[jflesch]

https://origami.openpaper.work/#/builders/2/builds/459

[jflesch]

Also the Python2 tests are broken because of a dependency loop in the modules (tesseract tries to import builder who tries to import tesseract.psm_parameter) ...

[jflesch]

(I should have run the tests before merging ...)

[jflesch]

you can run the tests and the checks with make test (requires tox) and make check (requires pyflake8)

[jflesch]

Actually, Python 3 tests are broken too.

[ddddavidmartin]

Oh no! Can you revert the merge on master and I'll update the pull request again?

I had not actually tried out the latest commit yet as I'm developing on a different machine from which I have my document scans running.

[jflesch]

Reverted: 7189c69

[jflesch]

By the way, Pyocr tests are unfortunately unreliable: OCR output differ too much from one system to another. --> you can (and must) run the tests to make sure that Pyocr seems to work, but in any case you will always have failed tests. You will have to look at the error messages: If PyOCR works, error messages will show that the tests failed due to the exact content returned by the OCR.

That's something I'll have to fix later. :/

[jflesch]

Actually, the code style errors returned by make check are my mistake. I'm fixing them right now.