Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov uploads #139

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Fix codecov uploads #139

merged 4 commits into from
Nov 21, 2024

Conversation

LDSamson
Copy link
Collaborator

@LDSamson LDSamson commented Nov 19, 2024

Fixes codecov uploads. Updates the workflow to the latest available one.

@LDSamson LDSamson changed the base branch from main to dev November 19, 2024 10:52
@LDSamson LDSamson changed the title Ls update codecov Fix codecov uploads Nov 21, 2024
@LDSamson LDSamson marked this pull request as ready for review November 21, 2024 15:10
@LDSamson
Copy link
Collaborator Author

@jthompson-arcus note that the old workflow might even work now, because James uploaded an organization-wide CODECOV_TOKEN. But this is according to the latest example workflow, probably more future proof, using https://github.com/r-lib/actions/blob/v2-branch/examples/test-coverage.yaml but with codecov-action V5: https://github.com/marketplace/actions/codecov#v5-release

Copy link
Collaborator

@jthompson-arcus jthompson-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@jthompson-arcus jthompson-arcus merged commit b2bd9bb into dev Nov 21, 2024
5 checks passed
@jthompson-arcus jthompson-arcus deleted the ls_update_codecov branch November 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants