Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change home nav position to sticky #1078

Merged
merged 1 commit into from
Mar 29, 2019
Merged

fix: Change home nav position to sticky #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/Home/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
margin-top: 40px;

&:first-child {
margin-top: 32px;
margin-top: 0;
}
}

.nav {
position: fixed;
position: sticky;
Copy link
Contributor Author

@liiil825 liiil825 Mar 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里只能让左边的滚动条改为和右边连动了，不然把左边高度少个底部的高度，一开始无法被感知到

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE 不支持sticky 定位

top: $header-height + $search-banner-height;
height: calc(100vh - #{$header-height} - #{$search-banner-height});
width: $home-nav-width;
Expand Down