Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Unified management for form sub-components #1110

Merged
merged 15 commits into from
Apr 25, 2019

Conversation

liiil825
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #1110 into master will increase coverage by 1.31%.
The diff coverage is 91.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
+ Coverage   63.66%   64.98%   +1.31%     
==========================================
  Files          85       86       +1     
  Lines        1277     1305      +28     
  Branches      358      369      +11     
==========================================
+ Hits          813      848      +35     
+ Misses        425      419       -6     
+ Partials       39       38       -1
Impacted Files Coverage Δ
src/components/Base/Modal/index.jsx 33.33% <ø> (ø) ⬆️
src/components/Base/Input/input.jsx 75% <100%> (ø) ⬆️
src/components/Base/Select/option.jsx 100% <100%> (ø) ⬆️
src/components/Base/Form/Field/index.jsx 100% <100%> (ø)
src/components/Base/Select/select.jsx 62.5% <84.61%> (+2.85%) ⬆️
src/components/Base/Form/form.jsx 93.33% <91.66%> (+38.78%) ⬆️
src/components/Base/Form/Field/FieldGroup.jsx 92.85% <92.85%> (ø)
src/components/Base/Form/Field/wrapField.jsx 94.73% <94.73%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280cb6a...78253a9. Read the comment docs.

@openpitrix openpitrix deleted a comment Apr 18, 2019
@openpitrix openpitrix deleted a comment Apr 18, 2019
@openpitrix openpitrix deleted a comment Apr 18, 2019
@openpitrix openpitrix deleted a comment Apr 18, 2019
@openpitrix openpitrix deleted a comment Apr 18, 2019
@openpitrix openpitrix deleted a comment Apr 19, 2019
@openpitrix openpitrix deleted a comment Apr 22, 2019
@openpitrix openpitrix deleted a comment Apr 22, 2019
@openpitrix openpitrix deleted a comment Apr 22, 2019
@openpitrix openpitrix deleted a comment Apr 22, 2019
@openpitrix openpitrix deleted a comment Apr 22, 2019
@liiil825 liiil825 changed the title [WIP]refactor: Unified management of form styles refactor: Unified management of form styles Apr 22, 2019
@liiil825 liiil825 requested review from sunnywx and whDongRui April 22, 2019 08:14
@openpitrix openpitrix deleted a comment Apr 22, 2019
@sunnywx sunnywx changed the title refactor: Unified management of form styles refactor: Unified management for form sub-components Apr 25, 2019
@sunnywx sunnywx merged commit 07218c7 into openpitrix:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants