Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Lighthouse audits #331

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Sep 6, 2018

Fix render-page middleware
Move assets to public folder
Fix config.yaml

Fix render-page middleware
Fix issues based on lighthouse audits
@sunnywx sunnywx requested a review from whDongRui September 6, 2018 08:00
@sunnywx
Copy link
Contributor Author

sunnywx commented Sep 6, 2018

fix #330

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #331 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   19.55%   19.62%   +0.06%     
==========================================
  Files          84       85       +1     
  Lines        1227     1228       +1     
  Branches      237      237              
==========================================
+ Hits          240      241       +1     
  Misses        948      948              
  Partials       39       39
Impacted Files Coverage Δ
src/components/Base/Icon/index.jsx 89.65% <ø> (ø) ⬆️
src/components/Nav/index.jsx 60% <ø> (ø) ⬆️
src/utils/icons.js 100% <ø> (ø)
src/components/Footer/index.jsx 0% <ø> (ø) ⬆️
src/components/Banner/index.jsx 0% <ø> (ø) ⬆️
src/components/TdName/index.jsx 0% <0%> (ø) ⬆️
src/components/Base/Image/index.jsx 0% <0%> (ø) ⬆️
src/components/Card/index.jsx 0% <0%> (ø) ⬆️
src/components/Header/index.jsx 0% <0%> (ø) ⬆️
src/components/Rectangle/AppImages/index.jsx 0% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc8cde...fae464b. Read the comment docs.

@sunnywx sunnywx merged commit e54ecee into openpitrix:master Sep 6, 2018
@sunnywx sunnywx deleted the refine/lighthouse-audit branch September 6, 2018 08:45
@sunnywx sunnywx restored the refine/lighthouse-audit branch September 6, 2018 08:45
@sunnywx sunnywx deleted the refine/lighthouse-audit branch September 6, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants