Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge develop branch #473

Merged
merged 7 commits into from
Oct 9, 2018
Merged

Merge develop branch #473

merged 7 commits into from
Oct 9, 2018

Conversation

sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Oct 9, 2018

Remove all onEnter preload in components
Refactor all pages, stores

sunnywx added 7 commits October 9, 2018 16:02
@sunnywx
feat: VM based cluster support addNodes, resizeCluster, deleteNodes
5727f64
@sunnywx
feat: remove all onEnter preload on server side, using client side …
5af0f13 
…fetch

Fix server architecture

Separate store files
@sunnywx
feat: Remove all pages onEnter preload, using componentDidMount
da5e22f 
Fix: move all component data reset to componentWillUnmount

Add user server provider

Refactor cluster detail, add VMbase and Helm components
@sunnywx
feat: VM based cluster support addNodes, resizeCluster, deleteNodes
a9f88ef
@sunnywx
feat: remove all onEnter preload on server side, using client side …
73d6906 
…fetch

Fix server architecture

Separate store files
@sunnywx
feat: Remove all pages onEnter preload, using componentDidMount
71f9afd 
Fix: move all component data reset to componentWillUnmount

Add user server provider

Refactor cluster detail, add VMbase and Helm components
@sunnywx
fix: Helm type cluster detail
4db57b1 
Fix cluster detail store
@sunnywx sunnywx requested a review from whDongRui October 9, 2018 09:56
@codecov
Copy link

codecov bot commented Oct 9, 2018 •
edited
Loading

Codecov Report

Merging #473 into master will increase coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   17.62%   17.81%   +0.19%     
==========================================
  Files          86       90       +4     
  Lines        1379     1381       +2     
  Branches      289      286       -3     
==========================================
+ Hits          243      246       +3     
+ Misses       1081     1080       -1     
  Partials       55       55
Impacted Files Coverage Δ
src/components/Layout/index.js 0% <ø> (ø) ⬆️
src/components/Layout/Portal/Dev/index.jsx 0% <0%> (ø)
src/components/Breadcrumb/index.jsx 0% <0%> (ø)
src/components/DetailCard/ClusterCard.jsx 0% <0%> (ø) ⬆️
src/components/Layout/SideNav/index.jsx 0% <0%> (ø)
src/components/DetailTabs/index.jsx 0% <0%> (ø)
src/components/Layout/Portal/Normal/index.jsx 0% <0%> (ø)
src/components/Layout/Dialog/index.jsx 0% <0%> (ø) ⬆️
src/components/Layout/BackBtn.jsx 0% <0%> (ø) ⬆️
src/components/Layout/index.jsx 0% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1ff11...4db57b1. Read the comment docs.

@sunnywx sunnywx mentioned this pull request Oct 9, 2018
Closed
@sunnywx sunnywx merged commit ebc5ac7 into master Oct 9, 2018
@sunnywx sunnywx mentioned this pull request Oct 9, 2018
Closed
@sunnywx sunnywx deleted the develop branch October 9, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whDongRui whDongRui whDongRui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnywx @whDongRui