Skip to content

Conversation

@sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Oct 9, 2018

Remove all onEnter preload in components
Refactor all pages, stores

…fetch

Fix server architecture

Separate store files
Fix: move all component data reset to componentWillUnmount

Add user server provider

Refactor cluster detail, add VMbase and Helm components
…fetch

Fix server architecture

Separate store files
Fix: move all component data reset to componentWillUnmount

Add user server provider

Refactor cluster detail, add VMbase and Helm components
Fix cluster detail store
@sunnywx sunnywx requested a review from whDongRui October 9, 2018 09:56
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #473 into master will increase coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   17.62%   17.81%   +0.19%     
==========================================
  Files          86       90       +4     
  Lines        1379     1381       +2     
  Branches      289      286       -3     
==========================================
+ Hits          243      246       +3     
+ Misses       1081     1080       -1     
  Partials       55       55
Impacted Files Coverage Δ
src/components/Layout/index.js 0% <ø> (ø) ⬆️
src/components/Layout/Portal/Dev/index.jsx 0% <0%> (ø)
src/components/Breadcrumb/index.jsx 0% <0%> (ø)
src/components/DetailCard/ClusterCard.jsx 0% <0%> (ø) ⬆️
src/components/Layout/SideNav/index.jsx 0% <0%> (ø)
src/components/DetailTabs/index.jsx 0% <0%> (ø)
src/components/Layout/Portal/Normal/index.jsx 0% <0%> (ø)
src/components/Layout/Dialog/index.jsx 0% <0%> (ø) ⬆️
src/components/Layout/BackBtn.jsx 0% <0%> (ø) ⬆️
src/components/Layout/index.jsx 0% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1ff11...4db57b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants