feat: Add vm config parser, unify vm and helm type app deployment #503
Conversation
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 17.5% 16.43% -1.08%
==========================================
Files 91 94 +3
Lines 1405 1497 +92
Branches 294 313 +19
==========================================
Hits 246 246
- Misses 1103 1195 +92
Partials 56 56
Continue to review full report at Codecov.
|
src/pages/TestDeploy/index.jsx
Outdated
| { title: 'Vxnet settings', items: this.parser.getVxnetSetting() } | ||
| ); | ||
|
|
||
| console.log('render data: ', groups); |
There was a problem hiding this comment.
All right, this pr is working in progress, later will remove test code
src/pages/TestDeploy/index.jsx
Outdated
|
|
||
| handleSubmit = e => { | ||
| e.preventDefault(); | ||
| console.log(getFormData(e.target)); |
Refactor app deployment
refactor vm config parser
sunnywx
force-pushed
the
feat/add-qingcloud-config-parser
branch
from
c86b422 to
1b88356
Compare
sunnywx
changed the title
Deploy page updated when changed runtime, version Fix test code
sunnywx
changed the title
| runtime_id: runtimeId, | ||
| limit: this.maxLimit | ||
| }); | ||
| this.subnets = get(result, 'subnet_set', []); | ||
| this.subnetId = this.subnets[0] ? this.subnets[0].subnet_id : ''; |
There was a problem hiding this comment.
No need remove this code. If selected subnet, then change selected runtime, the subnet will show previous value.
There was a problem hiding this comment.
No, if changed runtime, newly subnets will be fetched, previous subnet won't be set.
There was a problem hiding this comment.
Previous has a bug, after change runtime, query subnets no data, but the page subnet label show previous value.
| } else { | ||
| this.yamlConfig = []; | ||
| this.errMsg = 'Invalid config file, failed to render page'; |
There was a problem hiding this comment.
Add relatived translation.
Refactor app deployment