feat: Add new app detail page #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
whDongRui
commented
Jan 9, 2019
•
whDongRui
commented
- refactor: Modify Header and TitleBanner by design
- refactor: Modify app relatived url
- solve New app store detail page #631
* refactor: Modify Header and TitleBanner by design
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
========================================
+ Coverage 13.95% 14% +0.05%
========================================
Files 112 112
Lines 1849 1842 -7
Branches 401 400 -1
========================================
Hits 258 258
+ Misses 1523 1516 -7
Partials 68 68
Continue to review full report at Codecov.
|
sunnywx
reviewed
Jan 9, 2019
| @@ -13,21 +13,14 @@ const Account = lazy(() => import('../pages/Account')); | |||
| const Store = lazy(() => import('../pages/Store')); | |||
|
|
|||
| const routes = { | |||
| '/': Home, | |||
| // for no login | |||
liiil825
approved these changes
Jan 10, 2019
sunnywx
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.