fix: Page access role check, app card version type label #677

whDongRui · 2019-01-16T03:00:54Z

fix: My apps show error when version-types is null

* fix: My apps show error when version-types is null

codecov · 2019-01-16T03:03:29Z

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   24.08%   24.08%           
=======================================
  Files         109      109           
  Lines        1756     1756           
  Branches      402      402           
=======================================
  Hits          423      423           
  Misses       1262     1262           
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13428e8...2be3cef. Read the comment docs.

sunnywx · 2019-01-16T03:40:51Z

src/App.jsx

@@ -46,8 +46,7 @@ const WrapRoute = ({ component: Comp, ...rest }) => {

  if (!_.isEmpty(acl)) {
    acl = [].concat(acl);
-
-    if (!_.some(acl, role => user[`is${_.capitalize(role)}`])) {
+    if (!_.some(acl, role => user[`is${role}`])) {


如果之前的功能没问题，就尽量不去改。如果非要改，那也只是refactor，不是 fix

fix: Page access control to routes

2be3cef

* fix: My apps show error when version-types is null

whDongRui requested review from liiil825 and sunnywx January 16, 2019 03:00

sunnywx changed the title ~~fix: Page access control to routes~~ fix: App card version type label Jan 16, 2019

sunnywx approved these changes Jan 16, 2019

View reviewed changes

sunnywx reviewed Jan 16, 2019

View reviewed changes

sunnywx changed the title ~~fix: App card version type label~~ fix: Page access role check, app card version type label Jan 16, 2019

sunnywx merged commit 8aacb5d into openpitrix:master Jan 16, 2019

whDongRui deleted the fix/route-check branch January 17, 2019 06:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Page access role check, app card version type label #677

fix: Page access role check, app card version type label #677

whDongRui commented Jan 16, 2019

codecov bot commented Jan 16, 2019

sunnywx Jan 16, 2019

fix: Page access role check, app card version type label #677

fix: Page access role check, app card version type label #677

Conversation

whDongRui commented Jan 16, 2019

codecov bot commented Jan 16, 2019

Codecov Report

sunnywx Jan 16, 2019

Choose a reason for hiding this comment