Fix vehicle state for spectated player #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Fixes the issue of dashboard keys not showing for the currently viewed player; however, if GamePad type is 'None' (default?) it will disappear the controller/pad on dashboard unless forced to either kb or pad. |
|
Thanks! I will verify this soon. |
|
Looks good, thanks! 🎉 |
codecat
added a commit
that referenced
this pull request
Jan 4, 2024
…as faulty or just outdated, see #13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offset appears to be wrong and always returns the same player's vehicle state, regardless of who is being spectated.
With the new offset, spectating appears to work as intended,