FIX - Pylint issues part one #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed unused `imports`; - replaced unused variables with `_`; - removed unnecessary brackets and use of `(object)` in class declarations; and - added some missing DocStrings.
ablwr
reviewed
Oct 10, 2019
| @@ -1,7 +1,4 @@ | |||
| import os | |||
| import zipfile | |||
|
|
|||
| import pytest | |||
There was a problem hiding this comment.
Is pytest not required for the assert style syntax below, and zipfile for the ZipPackage namespace?
There was a problem hiding this comment.
Not in this case, only a native Python assert statement is used and here it is running on Travis: https://travis-ci.org/openpreserve/fido/jobs/596043501#L455 This also means that the code is optimised away in some circumstances but its fine for testing.
ablwr
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imports;_;(object)in class declarations; and